lkml.org 
[lkml]   [2020]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next v2 2/2] net: phy: DP83822: Add ability to advertise Fiber connection
From
Date
Andrew

On 7/11/20 1:45 PM, Andrew Lunn wrote:
>> +#define MII_DP83822_FIBER_ADVERTISE (SUPPORTED_AUI | SUPPORTED_FIBRE | \
>> + SUPPORTED_BNC | SUPPORTED_Pause | \
>> + SUPPORTED_Asym_Pause | \
>> + SUPPORTED_100baseT_Full)
>> +
>> + /* Setup fiber advertisement */
>> + err = phy_modify_changed(phydev, MII_ADVERTISE,
>> + ADVERTISE_1000XFULL |
>> + ADVERTISE_1000XPAUSE |
>> + ADVERTISE_1000XPSE_ASYM,
>> + MII_DP83822_FIBER_ADVERTISE);
> That looks very odd. SUPPORTED_AUI #define has nothing to do with
> MII_ADVERTISE register. It is not a bit you can read/write in that
> register.

ACK removed the SUPPORTED_AUI.

I also going to update the MII_DP83822_FIBER_ADVERTISE defines from
SUPPORTED_* to ADVERTISED_*

Dan


> Andrew

\
 
 \ /
  Last update: 2020-07-13 17:52    [W:0.043 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site