lkml.org 
[lkml]   [2020]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 12/25] pinctrl: pinmux: Add some missing parameter descriptions
    Date
    And rename another which has probably bitrotted.

    Fixes the following W=1 kernel build warning(s):

    drivers/pinctrl/pinmux.c:83: warning: Function parameter or member 'pctldev' not described in 'pinmux_can_be_used_for_gpio'
    drivers/pinctrl/pinmux.c:108: warning: Function parameter or member 'pctldev' not described in 'pin_request'
    drivers/pinctrl/pinmux.c:261: warning: Function parameter or member 'gpio' not described in 'pinmux_request_gpio'
    drivers/pinctrl/pinmux.c:751: warning: Function parameter or member 'selector' not described in 'pinmux_generic_get_function'
    drivers/pinctrl/pinmux.c:751: warning: Excess function parameter 'group_selector' description in 'pinmux_generic_get_function'

    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/pinctrl/pinmux.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
    index 9503ddf2edc76..bab888fe3f8e3 100644
    --- a/drivers/pinctrl/pinmux.c
    +++ b/drivers/pinctrl/pinmux.c
    @@ -74,6 +74,7 @@ int pinmux_validate_map(const struct pinctrl_map *map, int i)
    * pinmux_can_be_used_for_gpio() - check if a specific pin
    * is either muxed to a different function or used as gpio.
    *
    + * @pctldev: the associated pin controller device
    * @pin: the pin number in the global pin space
    *
    * Controllers not defined as strict will always return true,
    @@ -96,6 +97,7 @@ bool pinmux_can_be_used_for_gpio(struct pinctrl_dev *pctldev, unsigned pin)

    /**
    * pin_request() - request a single pin to be muxed in, typically for GPIO
    + * @pctldev: the associated pin controller device
    * @pin: the pin number in the global pin space
    * @owner: a representation of the owner of this pin; typically the device
    * name that controls its mux function, or the requested GPIO name
    @@ -254,6 +256,7 @@ static const char *pin_free(struct pinctrl_dev *pctldev, int pin,
    * @pctldev: pin controller device affected
    * @pin: the pin to mux in for GPIO
    * @range: the applicable GPIO range
    + * @gpio: number of requested GPIO
    */
    int pinmux_request_gpio(struct pinctrl_dev *pctldev,
    struct pinctrl_gpio_range *range,
    @@ -744,7 +747,7 @@ EXPORT_SYMBOL_GPL(pinmux_generic_get_function_groups);
    /**
    * pinmux_generic_get_function() - returns a function based on the number
    * @pctldev: pin controller device
    - * @group_selector: function number
    + * @selector: function number
    */
    struct function_desc *pinmux_generic_get_function(struct pinctrl_dev *pctldev,
    unsigned int selector)
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-07-13 16:50    [W:4.079 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site