Messages in this thread | | | Subject | Re: [PATCH 4/6] interconnect: qcom: Add SM8250 interconnect provider driver | From | Georgi Djakov <> | Date | Mon, 13 Jul 2020 16:30:21 +0300 |
| |
Hi Jonathan,
Thanks for posting these patches!
On 7/1/20 16:42, Jonathan Marek wrote: > Add driver for the Qualcomm interconnect buses found in SM8250 based > platforms. The topology consists of several NoCs that are controlled by > a remote processor that collects the aggregated bandwidth for each > master-slave pairs. > > Based on SC7180 driver and generated from downstream dts. > > Signed-off-by: Jonathan Marek <jonathan@marek.ca> > --- [..] > + > +static const struct of_device_id qnoc_of_match[] = { > + { .compatible = "qcom,sm8250-aggre1-noc", > + .data = &sm8250_aggre1_noc}, > + { .compatible = "qcom,sm8250-aggre2-noc", > + .data = &sm8250_aggre2_noc}, > + { .compatible = "qcom,sm8250-compute-noc", > + .data = &sm8250_compute_noc}, > + { .compatible = "qcom,sm8250-config-noc", > + .data = &sm8250_config_noc}, > + { .compatible = "qcom,sm8250-dc-noc", > + .data = &sm8250_dc_noc}, > + { .compatible = "qcom,sm8250-gem-noc", > + .data = &sm8250_gem_noc}, > + { .compatible = "qcom,sm8250-ipa-virt", > + .data = &sm8250_ipa_virt}, > + { .compatible = "qcom,sm8250-mc-virt", > + .data = &sm8250_mc_virt}, > + { .compatible = "qcom,sm8250-mmss-noc", > + .data = &sm8250_mmss_noc}, > + { .compatible = "qcom,sm8250-npu-noc", > + .data = &sm8250_npu_noc}, > + { .compatible = "qcom,sm8250-system-noc", > + .data = &sm8250_system_noc}, > + { .compatible = "qcom,sm8250-gem-noc-display", > + .data = &sm8250_gem_noc_display}, > + { .compatible = "qcom,sm8250-mc-virt-display", > + .data = &sm8250_mc_virt_display}, > + { .compatible = "qcom,sm8250-mmss-noc-display", > + .data = &sm8250_mmss_noc_display}, > + { }
My main concern here are the display RSC nodes. We should not add the nodes for voting on the display RSC, but use the "qcom,bcm-voters" property in DT to list both "hlos" and "disp" as bcm voters for gem-noc, mc-virt and mmss-noc.
Thanks, Georgi
| |