lkml.org 
[lkml]   [2020]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 5/5] power: supply: core: supply battery soc with decimal form
On Mon, Jul 13, 2020 at 12:03:40PM +0800, Qiwu Huang wrote:
> From: Qiwu Huang <huangqiwu@xiaomi.com>
>
> Broadcast battery soc with decimal form.
> soc_decimal is the decimal part of battery soc.
> soc_decimal_rate is update frequency of decimal
> part of battery soc.
> We want to report such as 0.01 to 99.99% to
> user space to improve user experience
> when do very quick charging.
>
> Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
> ---
> Documentation/ABI/testing/sysfs-class-power | 20 ++++++++++++++++++++
> drivers/power/supply/power_supply_sysfs.c | 2 ++
> include/linux/power_supply.h | 2 ++
> 3 files changed, 24 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> index f4234ba1684a..bcc8ccad8163 100644
> --- a/Documentation/ABI/testing/sysfs-class-power
> +++ b/Documentation/ABI/testing/sysfs-class-power
> @@ -349,6 +349,26 @@ Description:
> Access: Read
> Valid values: Represented in microvolts
>
> +What: /sys/class/power_supply/<supply_name>/soc_decimal,
> +Date: Jul 2020
> +Contact: jiangfei1@xiaomi.com
> +Description:
> + Broadcast battery soc with decimal form.
> + soc_decimal is the start decimal part of battery soc.
> +
> + Access: Read
> + Valid values: 0 - 100

How can "100" be a valid decimal form here if this is a percent?


> +
> +What: /sys/class/power_supply/<supply_name>/soc_decimal_rate,
> +Date: Jul 2020
> +Contact: jiangfei1@xiaomi.com
> +Description:
> + Broadcast battery soc with decimal form.
> + soc_decimal_rate is the decimal part of battery soc update freqency.
> +
> + Access: Read
> + Valid values: 0 - 100

I think you need to document this a lot better as I still don't really
understand what this is for or how to use it or report it.

And what does "soc" mean here?

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-07-13 10:45    [W:0.039 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site