lkml.org 
[lkml]   [2020]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] usb: hso: Fix debug compile warning on sparc32
From
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Mon, 13 Jul 2020 13:05:13 +0200

> On sparc32, tcflag_t is "unsigned long", unlike on all other
> architectures, where it is "unsigned int":
>
> drivers/net/usb/hso.c: In function ‘hso_serial_set_termios’:
> include/linux/kern_levels.h:5:18: warning: format ‘%d’ expects argument of type ‘unsigned int’, but argument 4 has type ‘tcflag_t {aka long unsigned int}’ [-Wformat=]
> drivers/net/usb/hso.c:1393:3: note: in expansion of macro ‘hso_dbg’
> hso_dbg(0x16, "Termios called with: cflags new[%d] - old[%d]\n",
> ^~~~~~~
> include/linux/kern_levels.h:5:18: warning: format ‘%d’ expects argument of type ‘unsigned int’, but argument 5 has type ‘tcflag_t {aka long unsigned int}’ [-Wformat=]
> drivers/net/usb/hso.c:1393:3: note: in expansion of macro ‘hso_dbg’
> hso_dbg(0x16, "Termios called with: cflags new[%d] - old[%d]\n",
> ^~~~~~~
>
> As "unsigned long" is 32-bit on sparc32, fix this by casting all tcflag_t
> parameters to "unsigned int".
> While at it, use "%u" to format unsigned numbers.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied, thanks.
\
 
 \ /
  Last update: 2020-07-14 02:05    [W:0.045 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site