lkml.org 
[lkml]   [2020]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/20] dlb2: add skeleton for DLB 2.0 driver
    On Sun, Jul 12, 2020 at 08:43:12AM -0500, Gage Eads wrote:
    > +config INTEL_DLB2
    > + tristate "Intel(R) Dynamic Load Balancer 2.0 Driver"
    > + depends on 64BIT && PCI && X86

    Why just that platform? What about CONFIG_TEST for everything else?

    > + help
    > + This driver supports the Intel(R) Dynamic Load Balancer 2.0 (DLB 2.0)
    > + device.

    Are you sure you need the (R) in Kconfig texts everywhere?

    And a bit more info here would be nice, as no one knows if they have
    this or not, right?

    > --- /dev/null
    > +++ b/drivers/misc/dlb2/dlb2_hw_types.h
    > @@ -0,0 +1,29 @@
    > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)

    Why dual licensed? I thought that Intel told me they were not going to
    do that anymore for any kernel code going forward as it was just such a
    pain and never actually helped anything. Has that changed?


    > + * Copyright(c) 2016-2020 Intel Corporation
    > + */
    > +
    > +#ifndef __DLB2_HW_TYPES_H
    > +#define __DLB2_HW_TYPES_H
    > +
    > +#define DLB2_MAX_NUM_VDEVS 16
    > +#define DLB2_MAX_NUM_DOMAINS 32
    > +#define DLB2_MAX_NUM_LDB_QUEUES 32 /* LDB == load-balanced */
    > +#define DLB2_MAX_NUM_DIR_QUEUES 64 /* DIR == directed */
    > +#define DLB2_MAX_NUM_LDB_PORTS 64
    > +#define DLB2_MAX_NUM_DIR_PORTS DLB2_MAX_NUM_DIR_QUEUES
    > +#define DLB2_MAX_NUM_LDB_CREDITS 8192
    > +#define DLB2_MAX_NUM_DIR_CREDITS 2048
    > +#define DLB2_MAX_NUM_HIST_LIST_ENTRIES 2048
    > +#define DLB2_MAX_NUM_AQED_ENTRIES 2048
    > +#define DLB2_MAX_NUM_QIDS_PER_LDB_CQ 8
    > +#define DLB2_MAX_NUM_SEQUENCE_NUMBER_GROUPS 2
    > +#define DLB2_MAX_NUM_SEQUENCE_NUMBER_MODES 5
    > +#define DLB2_QID_PRIORITIES 8
    > +#define DLB2_NUM_ARB_WEIGHTS 8
    > +#define DLB2_MAX_WEIGHT 255
    > +#define DLB2_NUM_COS_DOMAINS 4
    > +#define DLB2_MAX_CQ_COMP_CHECK_LOOPS 409600
    > +#define DLB2_MAX_QID_EMPTY_CHECK_LOOPS (32 * 64 * 1024 * (800 / 30))
    > +#define DLB2_HZ 800000000

    No tabs? How easy is that to read? :(

    greg k-h

    \
     
     \ /
      Last update: 2020-07-12 17:56    [W:3.558 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site