Messages in this thread | | | Date | Sat, 11 Jul 2020 12:30:53 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v6 08/17] static_call: Avoid kprobes on inline static_call()s |
| |
On Fri, Jul 10, 2020 at 06:00:14PM -0400, Steven Rostedt wrote:
> > +int static_call_text_reserved(void *start, void *end) > > +{ > > + int ret = __static_call_text_reserved(__start_static_call_sites, > > + __stop_static_call_sites, start, end); > > + > > + if (ret) > > + return ret; > > + > > +#ifdef CONFIG_MODULES > > + ret = __static_call_mod_text_reserved(start, end); > > +#endif > > Nit, but why not have a #else /* !CONFIG_MODULE */ above and just: > > static inline int __static_call_mod_text_reserve(..) > { > return 0; > } > #endif > > ?
Done.
| |