Messages in this thread | | | Date | Fri, 10 Jul 2020 14:53:01 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH v3] vmalloc: Add the right hint when vmalloc failed |
| |
On Fri, Jul 10, 2020 at 03:49:56PM +0200, Uladzislau Rezki wrote: > > On Fri, Jul 10, 2020 at 08:17:52PM +0800, Tian Tao wrote: > > > In fact "vmalloc=<size>" cmdline option is not available on many > > > platforms.When the user encounters this error, add the correct > > > hint to prevent misleading. > > > > i don't think this is an improvement. > > > Matthew, maybe it should not be considered as improvements?
Every patch should be an improvement along some dimension. This doesn't feel like an improvement in any way.
> It is rather an extra information that indicates that your > ARCH may not support "vmalloc" early parameter.
If anything needs to be improved, it's the documentation, not this error message.
| |