Messages in this thread | | | Date | Fri, 10 Jul 2020 13:24:59 +0100 | From | Mark Brown <> | Subject | Re: sound/soc/codecs/zl38060.c:614:34: warning: unused variable 'zl38_dt_ids' |
| |
On Thu, Jul 09, 2020 at 07:41:00PM -0700, Nathan Chancellor wrote:
> When CONFIG_SND_SOC_ZL38060 is y, MODULE_DEVICE_TABLE expands to nothing > so zl38_dt_ids will be unused. This is a pretty common construct in the > kernel and the only way I can think of to resolve this through the code > is by adding __used annotations to all of these variables, which I think > is overkill for this.
> Personally, I think this warning should be downgraded to W=2, thoughts?
We've had that warning available for ever, we shouldn't need to disable it now. I had thought there was supposed to be magic which caused of_match_ptr() to make things look referenced when !OF but don't seem to actually see any sign of it. The other thing is to just have ifdefs around the table. [unhandled content-type:application/pgp-signature] | |