Messages in this thread | | | Date | Fri, 10 Jul 2020 19:31:51 -0700 | From | Roman Gushchin <> | Subject | Re: [PATCH] mm: vmscan: consistent update to pgrefill |
| |
On Fri, Jul 10, 2020 at 06:14:59PM -0700, Shakeel Butt wrote: > The vmstat pgrefill is useful together with pgscan and pgsteal stats to > measure the reclaim efficiency. However vmstat's pgrefill is not updated > consistently at system level. It gets updated for both global and memcg > reclaim however pgscan and pgsteal are updated for only global reclaim. > So, update pgrefill only for global reclaim. If someone is interested in > the stats representing both system level as well as memcg level reclaim, > then consult the root memcg's memory.stat instead of /proc/vmstat. > > Signed-off-by: Shakeel Butt <shakeelb@google.com>
So you went into the opposite direction from the "previous version" ( https://lkml.org/lkml/2020/5/7/1464 ) ?
Acked-by: Roman Gushchin <guro@fb.com>
Thanks!
| |