Messages in this thread | | | Date | Fri, 10 Jul 2020 23:04:11 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH 2/4] fs: Remove FIRMWARE_PREALLOC_BUFFER from kernel_read_file() enums |
| |
On Fri, Jul 10, 2020 at 02:00:32PM -0700, Scott Branden wrote: > > @@ -950,8 +951,8 @@ int kernel_read_file(struct file *file, void **buf, loff_t *size, > > goto out; > > } > > - if (id != READING_FIRMWARE_PREALLOC_BUFFER) > > - *buf = vmalloc(i_size); > > + if (!*buf) > The assumption that *buf is always NULL when id != > READING_FIRMWARE_PREALLOC_BUFFER doesn't appear to be correct. > I get unhandled page faults due to this change on boot.
Did it give you a stack backtrace?
| |