lkml.org 
[lkml]   [2020]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] TI DAVINCI SERIES MEDIA DRIVER: Replace HTTP links with HTTPS ones
On Thu, Jul 9, 2020 at 9:43 AM Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
>
> Hi Alexander,
>
> On 09/07/2020 08:28, Alexander A. Klimov wrote:
> > Rationale:
> > Reduces attack surface on kernel devs opening the links for MITM
> > as HTTPS traffic is much harder to manipulate.
> >
> > Deterministic algorithm:
> > For each file:
> > If not .svg:
> > For each line:
> > If doesn't contain `\bxmlns\b`:
> > For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> > If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> > If both the HTTP and HTTPS versions
> > return 200 OK and serve the same content:
> > Replace HTTP with HTTPS.
> >
> > Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
>
> This non-https link redirects to the https link already with a 301, so
> the content is expectedly the same.
>
> I doubt many people click on these links, as I guess they're usually
> rendered as text so it depends on the editor, I expect as much as
> anything it's 'advertising' or confirmation of the copyright notice.
>
> But still, I've just clicked on them ... and I think this is a
> reasonable step.
>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>
> > ---
> > Continuing my work started at 93431e0607e5.
> > See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@al2klimov.de>' v5.7..master
> > (Actually letting a shell for loop submit all this stuff for me.)
> >
> > If there are any URLs to be removed completely or at least not HTTPSified:
> > Just clearly say so and I'll *undo my change*.
> > See also: https://lkml.org/lkml/2020/6/27/64
> >
> > If there are any valid, but yet not changed URLs:
> > See: https://lkml.org/lkml/2020/6/26/837
> >
> > If you apply the patch, please let me know.
> >
> >
> > drivers/media/platform/davinci/vpbe_display.c | 2 +-
> > drivers/media/platform/davinci/vpif.c | 2 +-
> > drivers/media/platform/davinci/vpif.h | 2 +-
> > drivers/media/platform/davinci/vpif_display.c | 2 +-
> > drivers/media/platform/davinci/vpif_display.h | 2 +-
> > include/media/davinci/vpbe_display.h | 2 +-
> > 6 files changed, 6 insertions(+), 6 deletions(-)
> >
Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
--Prabhakar

> > diff --git a/drivers/media/platform/davinci/vpbe_display.c b/drivers/media/platform/davinci/vpbe_display.c
> > index 7ab13eb7527d..d19bad997f30 100644
> > --- a/drivers/media/platform/davinci/vpbe_display.c
> > +++ b/drivers/media/platform/davinci/vpbe_display.c
> > @@ -1,6 +1,6 @@
> > // SPDX-License-Identifier: GPL-2.0-only
> > /*
> > - * Copyright (C) 2010 Texas Instruments Incorporated - http://www.ti.com/
> > + * Copyright (C) 2010 Texas Instruments Incorporated - https://www.ti.com/
> > */
> > #include <linux/kernel.h>
> > #include <linux/init.h>
> > diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c
> > index df66461f5d4f..e9794c9fc7fe 100644
> > --- a/drivers/media/platform/davinci/vpif.c
> > +++ b/drivers/media/platform/davinci/vpif.c
> > @@ -5,7 +5,7 @@
> > * The hardware supports SDTV, HDTV formats, raw data capture.
> > * Currently, the driver supports NTSC and PAL standards.
> > *
> > - * Copyright (C) 2009 Texas Instruments Incorporated - http://www.ti.com/
> > + * Copyright (C) 2009 Texas Instruments Incorporated - https://www.ti.com/
> > *
> > * This program is free software; you can redistribute it and/or
> > * modify it under the terms of the GNU General Public License as
> > diff --git a/drivers/media/platform/davinci/vpif.h b/drivers/media/platform/davinci/vpif.h
> > index 2466c7c77deb..c6d1d890478a 100644
> > --- a/drivers/media/platform/davinci/vpif.h
> > +++ b/drivers/media/platform/davinci/vpif.h
> > @@ -1,7 +1,7 @@
> > /*
> > * VPIF header file
> > *
> > - * Copyright (C) 2009 Texas Instruments Incorporated - http://www.ti.com/
> > + * Copyright (C) 2009 Texas Instruments Incorporated - https://www.ti.com/
> > *
> > * This program is free software; you can redistribute it and/or
> > * modify it under the terms of the GNU General Public License as
> > diff --git a/drivers/media/platform/davinci/vpif_display.c b/drivers/media/platform/davinci/vpif_display.c
> > index 7d55fd45240e..46afc029138f 100644
> > --- a/drivers/media/platform/davinci/vpif_display.c
> > +++ b/drivers/media/platform/davinci/vpif_display.c
> > @@ -2,7 +2,7 @@
> > * vpif-display - VPIF display driver
> > * Display driver for TI DaVinci VPIF
> > *
> > - * Copyright (C) 2009 Texas Instruments Incorporated - http://www.ti.com/
> > + * Copyright (C) 2009 Texas Instruments Incorporated - https://www.ti.com/
> > * Copyright (C) 2014 Lad, Prabhakar <prabhakar.csengg@gmail.com>
> > *
> > * This program is free software; you can redistribute it and/or
> > diff --git a/drivers/media/platform/davinci/vpif_display.h b/drivers/media/platform/davinci/vpif_display.h
> > index af2765fdcea8..f731a65eefd6 100644
> > --- a/drivers/media/platform/davinci/vpif_display.h
> > +++ b/drivers/media/platform/davinci/vpif_display.h
> > @@ -1,7 +1,7 @@
> > /*
> > * VPIF display header file
> > *
> > - * Copyright (C) 2009 Texas Instruments Incorporated - http://www.ti.com/
> > + * Copyright (C) 2009 Texas Instruments Incorporated - https://www.ti.com/
> > *
> > * This program is free software; you can redistribute it and/or
> > * modify it under the terms of the GNU General Public License as
> > diff --git a/include/media/davinci/vpbe_display.h b/include/media/davinci/vpbe_display.h
> > index 56d05a855140..6d2a93740130 100644
> > --- a/include/media/davinci/vpbe_display.h
> > +++ b/include/media/davinci/vpbe_display.h
> > @@ -1,6 +1,6 @@
> > /* SPDX-License-Identifier: GPL-2.0-only */
> > /*
> > - * Copyright (C) 2010 Texas Instruments Incorporated - http://www.ti.com/
> > + * Copyright (C) 2010 Texas Instruments Incorporated - https://www.ti.com/
> > */
> > #ifndef VPBE_DISPLAY_H
> > #define VPBE_DISPLAY_H
> >
>

\
 
 \ /
  Last update: 2020-07-10 09:16    [W:0.040 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site