lkml.org 
[lkml]   [2020]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 08/40] btrfs: use kfree() in btrfs_ioctl_get_subvol_info()
    Date
    From: Waiman Long <longman@redhat.com>

    [ Upstream commit b091f7fede97cc64f7aaad3eeb37965aebee3082 ]

    In btrfs_ioctl_get_subvol_info(), there is a classic case where kzalloc()
    was incorrectly paired with kzfree(). According to David Sterba, there
    isn't any sensitive information in the subvol_info that needs to be
    cleared before freeing. So kzfree() isn't really needed, use kfree()
    instead.

    Signed-off-by: Waiman Long <longman@redhat.com>
    Reviewed-by: David Sterba <dsterba@suse.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/btrfs/ioctl.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
    index d88b8d8897cc5..08d8bb421848a 100644
    --- a/fs/btrfs/ioctl.c
    +++ b/fs/btrfs/ioctl.c
    @@ -2735,7 +2735,7 @@ static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp)

    out:
    btrfs_free_path(path);
    - kzfree(subvol_info);
    + kfree(subvol_info);
    return ret;
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-07-02 03:26    [W:4.039 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site