lkml.org 
[lkml]   [2020]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 03/11] arm64: dts: renesas: hihope-common: Separate out Rev.2.0 specific into hihope-common-rev2.dtsi file
    Hi Prabhakar,

    Thanks for your patch!

    On Sun, Jun 7, 2020 at 8:41 PM Lad Prabhakar
    <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
    > Separate out Rev.2.0 specific hardware changes into
    > hihope-common-rev2.dtsi file so that hihope-common.dtsi can be used
    > by all the variants for RZ/G2M[N] boards.
    >
    > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
    > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>

    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

    > --- /dev/null
    > +++ b/arch/arm64/boot/dts/renesas/hihope-common-rev2.dtsi
    > @@ -0,0 +1,101 @@
    > +// SPDX-License-Identifier: GPL-2.0
    > +/*
    > + * Device Tree Source for the HiHope RZ/G2[MN] main board Rev.2.0 common
    > + * parts
    > + *
    > + * Copyright (C) 2020 Renesas Electronics Corp.
    > + */
    > +
    > +#include <dt-bindings/gpio/gpio.h>

    What about adding

    #include "hihope-common.dtsi"

    here?
    Then the *rev2.dts files have to include only "hihope-common-rev2.dtsi",
    and get "hihope-common.dtsi" for free?

    The same is true for the rev4.dtsi and the rev4.dts files.

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2020-06-08 16:29    [W:6.276 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site