lkml.org 
[lkml]   [2020]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [RFC PATCH net-next 05/10] Documentation: networking: ethtool-netlink: Add link extended state
Date
Andrew Lunn <andrew@lunn.ch> writes:

>> +Link extended states:
>> +
>> + ============================ =============================================
>> + ``Autoneg failure`` Failure during auto negotiation mechanism
>
>I think you need to define 'failure' here.
>
>Linux PHYs don't have this state. auto-neg is either ongoing, or has completed. There is no time limit for auto-neg. If there is no link partner, auto-neg does not fail, it just continues until there is a link partner which responds and negotiation completes.
>
>Looking at the state diagrams in 802.3 clause 28, what do you consider as failure?
>

Ok, you're right. What about renaming this state to "Autoneg issue" and then as ext_substate you can use something like "Autoneg ongoing"?

> Andrew

\
 
 \ /
  Last update: 2020-06-08 12:02    [W:0.467 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site