lkml.org 
[lkml]   [2020]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Forest Bond <>,Greg Kroah-Hartman <>,,


On Mon, 8 Jun 2020, Al Viro wrote:

> On Sun, Jun 07, 2020 at 10:41:56PM +0000, Rodolfo C. Villordo wrote:
> > Multiple line over 80 characters fixes by splitting in multiple lines.
> > Warning found by checkpatch.pl
>
> I doubt that checkpatch.pl can catch the real problems there:
>
> * Hungarian Notation Sucks. Really.
> * so does CamelCase, especially for wonders like s_uGetRTSCTSRsvTime

Rodolfo,

If you work hard with Coccinelle and python scripting, it can help with
the first two problems.

julia


> * local variables are useful
> * if a long expression keeps cropping up all over the place, you
> probably are missing an inline helper.
>
> PS: this
> > - buf->time_stamp_off_a = vnt_time_stamp_off(pDevice, wCurrentRate);
> > - buf->time_stamp_off_b = vnt_time_stamp_off(pDevice, pDevice->byTopCCKBasicRate);
> > + buf->time_stamp_off_a =
> > + vnt_time_stamp_off(pDevice, wCurrentRate);
> > + buf->time_stamp_off_b =
> > + vnt_time_stamp_off(pDevice,
> > + pDevice->byTopCCKBasicRate);
> is no improvement.
>

\
 
 \ /
  Last update: 2020-06-08 08:00    [W:0.067 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site