lkml.org 
[lkml]   [2020]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.7 097/274] media: venus: core: remove CNOC voting while device suspend
    Date
    From: Mansur Alisha Shaik <mansur@codeaurora.org>

    [ Upstream commit 07f8f22a33a9e3e9955e24a84e2f856dcc8c31c4 ]

    The Venus driver is voting Configuration NoC during .probe but not clear
    voting in .suspend. Because of this NoC is up during shutdown also. As a
    consequence the whole device could leak energy while in .suspend.

    So correct this by moving voting in .resume and unvoting
    in .suspend

    Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
    Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/qcom/venus/core.c | 12 ++++++++----
    1 file changed, 8 insertions(+), 4 deletions(-)

    diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
    index 194b10b98767..13fa5076314c 100644
    --- a/drivers/media/platform/qcom/venus/core.c
    +++ b/drivers/media/platform/qcom/venus/core.c
    @@ -242,10 +242,6 @@ static int venus_probe(struct platform_device *pdev)
    if (ret)
    return ret;

    - ret = icc_set_bw(core->cpucfg_path, 0, kbps_to_icc(1000));
    - if (ret)
    - return ret;
    -
    ret = hfi_create(core, &venus_core_ops);
    if (ret)
    return ret;
    @@ -350,6 +346,10 @@ static __maybe_unused int venus_runtime_suspend(struct device *dev)
    if (ret)
    return ret;

    + ret = icc_set_bw(core->cpucfg_path, 0, 0);
    + if (ret)
    + return ret;
    +
    if (pm_ops->core_power)
    ret = pm_ops->core_power(dev, POWER_OFF);

    @@ -368,6 +368,10 @@ static __maybe_unused int venus_runtime_resume(struct device *dev)
    return ret;
    }

    + ret = icc_set_bw(core->cpucfg_path, 0, kbps_to_icc(1000));
    + if (ret)
    + return ret;
    +
    return hfi_core_resume(core, false);
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-09 03:01    [W:5.547 / U:0.688 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site