Messages in this thread | | | Subject | Re: [PATCH v3] Bluetooth: Allow suspend even when preparation has failed | From | Marcel Holtmann <> | Date | Mon, 8 Jun 2020 10:17:05 +0200 |
| |
Hi Abhishek,
> It is preferable to allow suspend even when Bluetooth has problems > preparing for sleep. When Bluetooth fails to finish preparing for > suspend, log the error and allow the suspend notifier to continue > instead. > > To also make it clearer why suspend failed, change bt_dev_dbg to > bt_dev_err when handling the suspend timeout. > > Fixes: dd522a7429b07e ("Bluetooth: Handle LE devices during suspend") > Reported-by: Len Brown <len.brown@intel.com> > Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> > --- > To verify this is properly working, I added an additional change to > hci_suspend_wait_event to always return -16. This validates that suspend > continues even when an error has occurred during the suspend > preparation. > > Example on Chromebook: > [ 55.834524] PM: Syncing filesystems ... done. > [ 55.841930] PM: Preparing system for sleep (s2idle) > [ 55.940492] Bluetooth: hci_core.c:hci_suspend_notifier() hci0: Suspend notifier action (3) failed: -16 > [ 55.940497] Freezing user space processes ... (elapsed 0.001 seconds) done. > [ 55.941692] OOM killer disabled. > [ 55.941693] Freezing remaining freezable tasks ... (elapsed 0.000 seconds) done. > [ 55.942632] PM: Suspending system (s2idle) > > I ran this through a suspend_stress_test in the following scenarios: > * Peer classic device connected: 50+ suspends > * No devices connected: 100 suspends > * With the above test case returning -EBUSY: 50 suspends > > I also ran this through our automated testing for suspend and wake on > BT from suspend continues to work. > > > Changes in v3: > - Changed printf format for unsigned long > > Changes in v2: > - Added fixes and reported-by tags > > net/bluetooth/hci_core.c | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
| |