Messages in this thread | | | Subject | Re: [PATCH] media: staging: tegra-vde: add missing pm_runtime_put_autosuspend | From | Jon Hunter <> | Date | Fri, 5 Jun 2020 07:00:47 +0100 |
| |
On 02/06/2020 06:48, Navid Emamdoost wrote: > Call to pm_runtime_get_sync increments counter even in case of > failure leading to incorrect ref count. > Call pm_runtime_put_autosuspend if pm_runtime_get_sync fails. > > Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> > --- > drivers/staging/media/tegra-vde/vde.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/tegra-vde/vde.c b/drivers/staging/media/tegra-vde/vde.c > index d3e63512a765..52cdd4a91e93 100644 > --- a/drivers/staging/media/tegra-vde/vde.c > +++ b/drivers/staging/media/tegra-vde/vde.c > @@ -776,8 +776,10 @@ static int tegra_vde_ioctl_decode_h264(struct tegra_vde *vde, > goto release_dpb_frames; > > ret = pm_runtime_get_sync(dev); > - if (ret < 0) > + if (ret < 0) { > + pm_runtime_put_autosuspend(dev); > goto unlock; > + } > > /* > * We rely on the VDE registers reset value, otherwise VDE
Please use the put in the error path.
Jon
-- nvpublic
| |