| From | Andy Shevchenko <> | Date | Fri, 5 Jun 2020 11:07:32 +0300 | Subject | Re: [PATCH v4 03/11] irqchip: add sl28cpld interrupt controller support |
| |
On Fri, Jun 5, 2020 at 12:13 AM Michael Walle <michael@walle.cc> wrote: > > Add support for the interrupt controller inside the sl28 CPLD management > controller. > > The interrupt controller can handle at most 8 interrupts and is really > simplistic and consists only of an interrupt mask and an interrupt > pending register.
...
> +config SL28CPLD_INTC > + bool
Same Q: Why not module?
...
> +static const struct of_device_id sl28cpld_intc_of_match[] = { > + { .compatible = "kontron,sl28cpld-intc" },
> + {},
There is no point to have comma in terminator line.
> +};
-- With Best Regards, Andy Shevchenko
|