lkml.org 
[lkml]   [2020]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/7] selftests/ftrace: Add "requires:" list support
Hi Steve,

On Wed, 3 Jun 2020 10:33:43 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 3 Jun 2020 08:51:13 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > On Tue, 2 Jun 2020 09:21:45 -0400
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > On Tue, 2 Jun 2020 18:08:31 +0900
> > > Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > >
> > > > +++ b/tools/testing/selftests/ftrace/test.d/template
> > > > @@ -1,6 +1,7 @@
> > > > #!/bin/sh
> > > > # SPDX-License-Identifier: GPL-2.0
> > > > # description: %HERE DESCRIBE WHAT THIS DOES%
> > > > +# requires: %HERE LIST UP REQUIRED FILES%
> > >
> > > Not sure what you mean by "LIST UP". Perhaps you mean "LIST OF"?
> >
> > Ah, perhups we don't need UP. "list the required files" will be OK?
> >
> >
>
> Yes, that sounds much better.
>
> I tested out the patches with a few different configurations, and they all
> look good.
>
> Although I found that the irqsoff_tracer.tc (test for the preemptirqsoff
> tracer) changed from UNRESOLVED to UNSUPPORTED.

Yes, I think it should be unsupported if the kernel doesn't configure the
feature.

>
> I'll run a few more different configs and see what happens, but you can add:
>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Thanks, and I've already sent v3.

https://lkml.kernel.org/r/159115200085.70027.6141550347953439240.stgit@devnote2


Thank you,


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2020-06-04 17:10    [W:0.061 / U:0.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site