Messages in this thread | | | Subject | Re: [PATCH v2 2/2] dt-bindings: gpio: Add bindings for NXP PCA9570 | From | Sungbo Eo <> | Date | Wed, 1 Jul 2020 01:06:54 +0900 |
| |
On 2020-06-30 07:01, Rob Herring wrote: > On Thu, 25 Jun 2020 16:59:57 +0900, Sungbo Eo wrote: >> This patch adds device tree bindings for the NXP PCA9570, >> a 4-bit I2C GPO expander. >> >> Signed-off-by: Sungbo Eo <mans0n@gorani.run> >> --- >> I don't feel I can really maintain this driver, but it seems all yaml docs >> have a maintainers field so I just added it... >> --- >> .../bindings/gpio/gpio-pca9570.yaml | 42 +++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml >> > > > My bot found errors running 'make dt_binding_check' on your patch: > > Documentation/devicetree/bindings/gpio/gpio-pca9570.example.dts:21.13-26: Warning (reg_format): /example-0/gpio@24:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) > Documentation/devicetree/bindings/gpio/gpio-pca9570.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/gpio/gpio-pca9570.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/gpio/gpio-pca9570.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/gpio/gpio-pca9570.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/gpio/gpio-pca9570.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format' > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/gpio/gpio-pca9570.example.dt.yaml: example-0: gpio@24:reg:0: [36] is too short > > > See https://patchwork.ozlabs.org/patch/1316796 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. >
Thank you for pointing it out! I didn't noticed it. I'll re-submit an updated patch soon.
| |