lkml.org 
[lkml]   [2020]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] usb: mtu3: Fix NULL pointer dereferences
From
Date
> Some pointers are dereferenced before successful checks.

I propose to reconsider and improve also this change description.

* Would a null pointer dereference be possible only with the variables “mep”
and “mreq” in the implementation of the function “mtu3_gadget_dequeue”?
(Can it make sense to split the patch according to this detail?)

* How do you think about to convert any more variable initialisations
to later assignments?

* Will it become helpful to add the tag “Fixes” to the commit message?



> ---
> v2: nothing changed, but abandon another patch

Are there chances to take any previous patch review comments better into account
(besides the shown reduction of update steps)?


> ---
> drivers/usb/mtu3/mtu3_gadget.c | 25 ++++++++++++++++++-------

I suggest to replace the triple dashes before this diffstat by a blank line.

Regards,
Markus

\
 
 \ /
  Last update: 2020-06-30 12:48    [W:0.077 / U:8.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site