lkml.org 
[lkml]   [2020]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio: adc: Specify IOMEM dependency for adi-axi-adc driver
On Tue, 30 Jun 2020 00:05:52 -0700
David Gow <davidgow@google.com> wrote:

> The Analog Devices AXI ADC driver uses the devm_ioremap_resource
> function, but does not specify a dependency on IOMEM in Kconfig. This
> causes a build failure on architectures without IOMEM, for example, UML
> (notably with make allyesconfig).
>
> Fix this by making CONFIG_ADI_AXI_ADC depend on CONFIG_IOMEM.
>
> Signed-off-by: David Gow <davidgow@google.com>
Hi David,

Could you confirm what the build error is? I thought the stubs added in
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1bcbfbfdeb
were meant to allow us to avoid having lots of depends on IOMEM lines for the
few architectures who don't support it.

Jonathan

> ---
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index ff3569635ce0..f5009b61b80c 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -263,6 +263,7 @@ config AD9467
>
> config ADI_AXI_ADC
> tristate "Analog Devices Generic AXI ADC IP core driver"
> + depends on IOMEM
> select IIO_BUFFER
> select IIO_BUFFER_HW_CONSUMER
> select IIO_BUFFER_DMAENGINE


\
 
 \ /
  Last update: 2020-06-30 12:08    [W:0.050 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site