On Tue, Jun 30, 2020 at 07:42:58AM +0000, Chen Ni wrote:> Use offset_in_page macro instead of (addr & ~PAGE_MASK).Shees, so now we're replacing a trivial expression with something that'sactually longer to type? How does that make sense?> - memcpy(dst, kaddr + (vaddr & ~PAGE_MASK), len);> + memcpy(dst, kaddr + offset_in_page(vaddr), len);