lkml.org 
[lkml]   [2020]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] usb: mtu3: fix NULL pointer dereference
From
Date
On Mon, 2020-06-29 at 10:00 +0200, Markus Elfring wrote:
> > Some pointers are dereferenced before successful checks.
>
> I suggest to reconsider and improve the change description.
>
> * Would a null pointer dereference be possible only with the variables “mep”
> and “mreq” in the implementation of the function “mtu3_gadget_dequeue”?
>
> * How do you think about to adjust any more variable initialisations?
Yes, I'll do it if need, thanks

>
> * Will it become helpful to add the tag “Fixes” to the commit message?
Maybe needn't

>
> Regards,
> Markus

\
 
 \ /
  Last update: 2020-06-30 09:30    [W:0.039 / U:3.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site