Messages in this thread Patch in this message | | | From | Jianyong Wu <> | Subject | [PATCH v2] 9p: retrieve fid from file when file instance exist. | Date | Wed, 1 Jul 2020 10:38:21 +0800 |
| |
In the current setattr implementation in 9p, fid is always retrieved from dentry no matter file instance exists or not. There may be some info related to opened file instance dropped. so it's better to retrieve fid from file instance if file instance is passed to setattr.
for example: fd=open("tmp", O_RDWR); ftruncate(fd, 10);
The file context related with fd will be lost as fid is always retrieved from dentry, then the backend can't get the info of file context. It is against the original intention of user and may lead to bug.
Signed-off-by: Jianyong Wu <jianyong.wu@arm.com> --- fs/9p/vfs_inode.c | 6 +++++- fs/9p/vfs_inode_dotl.c | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c index c9255d399917..b33574d347fa 100644 --- a/fs/9p/vfs_inode.c +++ b/fs/9p/vfs_inode.c @@ -1100,7 +1100,11 @@ static int v9fs_vfs_setattr(struct dentry *dentry, struct iattr *iattr) retval = -EPERM; v9ses = v9fs_dentry2v9ses(dentry); - fid = v9fs_fid_lookup(dentry); + if (iattr->ia_valid & ATTR_FILE) { + fid = iattr->ia_file->private_data; + WARN_ON(!fid); + } else + fid = v9fs_fid_lookup(dentry); if(IS_ERR(fid)) return PTR_ERR(fid); diff --git a/fs/9p/vfs_inode_dotl.c b/fs/9p/vfs_inode_dotl.c index 60328b21c5fb..ae714f1a630f 100644 --- a/fs/9p/vfs_inode_dotl.c +++ b/fs/9p/vfs_inode_dotl.c @@ -560,7 +560,11 @@ int v9fs_vfs_setattr_dotl(struct dentry *dentry, struct iattr *iattr) p9attr.mtime_sec = iattr->ia_mtime.tv_sec; p9attr.mtime_nsec = iattr->ia_mtime.tv_nsec; - fid = v9fs_fid_lookup(dentry); + if (iattr->ia_valid & ATTR_FILE) { + fid = iattr->ia_file->private_data; + WARN_ON(!fid); + } else + fid = v9fs_fid_lookup(dentry); if (IS_ERR(fid)) return PTR_ERR(fid); -- 2.17.1
| |