lkml.org 
[lkml]   [2020]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/2] gpio: add GPO driver for PCA9570
On Tue, Jun 30, 2020 at 7:11 PM Sungbo Eo <mans0n@gorani.run> wrote:
>
> Thanks for all the reviews! I've updated the patch, please have a look.
>
> And I have something to ask.
>
> # echo 1 > gpio408/value
> # cat gpio408/value
> cat: read error: I/O error
> # cat gpio408/direction
> out
> # echo out > gpio408/direction
> # echo in > gpio408/direction
> [ 91.006691] gpio-408 (sysfs): gpiod_direction_input: missing get()
> but have direction_input()
> ash: write error: I/O error
>
> I've never dealt with GPO expander before, so this seems a bit odd to me.
> Is it perfectly okay to leave get() and direction_input() unimplemented?

Actually it would be better to return the value you set for output in ->get().


--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-06-30 23:24    [W:0.046 / U:7.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site