lkml.org 
[lkml]   [2020]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] media: budget-core: Improve exception handling in budget_register()
From
Date
> Add the missed undo functions for error handling to fix it.


> +++ b/drivers/media/pci/ttpci/budget-core.c
> @@ -369,20 +369,25 @@ static int budget_register(struct budget *budget)

> return 0;
> +
+err:
> + dvb_dmxdev_release(&budget->dmxdev);
> + dvb_dmx_release(&budget->demux);
> + return ret;
> }


Perhaps use the label “release_dmxdev” instead?

Regards,
Markus

\
 
 \ /
  Last update: 2020-06-03 20:25    [W:0.686 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site