Messages in this thread | | | Date | Wed, 3 Jun 2020 12:16:28 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH v2 1/3] crash: add VMCOREINFO macro for anonymous structs |
| |
On Fri 2020-05-01 11:46:08, John Ogness wrote: > Some structs are not named and are only available via their typedef. > Add a VMCOREINFO macro to export field offsets for such structs.
Honestly, I did not get the meaning until I looked at the sample usage added by the 2nd patch.
The term "anonymous structures" has another meaning in C++. It is used for structures without any name that are defined inside a named structure.
Something like this might be better:
"crash: Add VMCOREINFO macro to define offset in a struct declared by typedef
The existing macro VMCOREINFO_OFFSET() can't be used for structures declared via typedef because "struct" is not part of type definition.
Create another macro for this purpose."
Anyway, thanks a lot for the prototype of crash implementation. I am happy that it is possible.
Best Regards, Petr
PS: It might take few more days until I send some feedback for the other patches. They are a bit more complex ;-)
| |