Messages in this thread | | | From | Chunyan Zhang <> | Date | Wed, 3 Jun 2020 17:17:34 +0800 | Subject | Re: [PATCH] [RFC] clk: sprd: fix compile-testing |
| |
On Thu, Apr 9, 2020 at 2:57 AM Arnd Bergmann <arnd@arndb.de> wrote: > > I got a build failure with CONFIG_ARCH_SPRD=m when the > main portion of the clock driver failed to get linked into > the kernel: > > ERROR: modpost: "sprd_pll_sc_gate_ops" [drivers/clk/sprd/sc9863a-clk.ko] undefined! > ERROR: modpost: "sprd_pll_ops" [drivers/clk/sprd/sc9863a-clk.ko] undefined! > ERROR: modpost: "sprd_div_ops" [drivers/clk/sprd/sc9863a-clk.ko] undefined! > ERROR: modpost: "sprd_comp_ops" [drivers/clk/sprd/sc9863a-clk.ko] undefined! > ERROR: modpost: "sprd_mux_ops" [drivers/clk/sprd/sc9863a-clk.ko] undefined! > ERROR: modpost: "sprd_gate_ops" [drivers/clk/sprd/sc9863a-clk.ko] undefined! > ERROR: modpost: "sprd_sc_gate_ops" [drivers/clk/sprd/sc9863a-clk.ko] undefined! > ERROR: modpost: "sprd_clk_probe" [drivers/clk/sprd/sc9863a-clk.ko] undefined! > ERROR: modpost: "sprd_clk_regmap_init" [drivers/clk/sprd/sc9863a-clk.ko] undefined! > ERROR: modpost: "sprd_pll_ops" [drivers/clk/sprd/sc9860-clk.ko] undefined! > ERROR: modpost: "sprd_div_ops" [drivers/clk/sprd/sc9860-clk.ko] undefined! > ERROR: modpost: "sprd_mux_ops" [drivers/clk/sprd/sc9860-clk.ko] undefined! > > This is a combination of two trivial bugs: > > - A platform should not be 'tristate', it should be a 'bool' symbol > like the other platforms, if only for consistency, and to avoid > surprises like this one. > > - The clk Makefile does not traverse into the sprd subdirectory > if the platform is disabled but the drivers are enabled for > compile-testing. > > Fixing either of the two would be sufficient to address the link failure, > but for correctness, both need to be changed. > > Fixes: 2b1b799d7630 ("arm64: change ARCH_SPRD Kconfig to tristate") > Fixes: d41f59fd92f2 ("clk: sprd: Add common infrastructure") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Hi,
This patch seems not been applied to next branch? I haven't seen it on linux-next. Arnd, can you please pick it to your tree. In case you need my ack: Acked-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
Thanks, Chunyan
> --- > arch/arm64/Kconfig.platforms | 2 +- > drivers/clk/Makefile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 55d70cfe0f9e..3c7e310fd8bf 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -248,7 +248,7 @@ config ARCH_TEGRA > This enables support for the NVIDIA Tegra SoC family. > > config ARCH_SPRD > - tristate "Spreadtrum SoC platform" > + bool "Spreadtrum SoC platform" > help > Support for Spreadtrum ARM based SoCs > > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile > index f4169cc2fd31..60e811d3f226 100644 > --- a/drivers/clk/Makefile > +++ b/drivers/clk/Makefile > @@ -105,7 +105,7 @@ obj-$(CONFIG_CLK_SIFIVE) += sifive/ > obj-$(CONFIG_ARCH_SIRF) += sirf/ > obj-$(CONFIG_ARCH_SOCFPGA) += socfpga/ > obj-$(CONFIG_PLAT_SPEAR) += spear/ > -obj-$(CONFIG_ARCH_SPRD) += sprd/ > +obj-y += sprd/ > obj-$(CONFIG_ARCH_STI) += st/ > obj-$(CONFIG_ARCH_STRATIX10) += socfpga/ > obj-$(CONFIG_ARCH_SUNXI) += sunxi/ > -- > 2.26.0 >
| |