lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 40/78] efi/esrt: Fix reference count leak in esre_create_sysfs_entry.
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    [ Upstream commit 4ddf4739be6e375116c375f0a68bf3893ffcee21 ]

    kobject_init_and_add() takes reference even when it fails.
    If this function returns an error, kobject_put() must be called to
    properly clean up the memory associated with the object. Previous
    commit "b8eb718348b8" fixed a similar problem.

    Fixes: 0bb549052d33 ("efi: Add esrt support")
    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Link: https://lore.kernel.org/r/20200528183804.4497-1-wu000273@umn.edu
    Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/firmware/efi/esrt.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
    index f3c28777b8c6f..deb1d8f3bdc8c 100644
    --- a/drivers/firmware/efi/esrt.c
    +++ b/drivers/firmware/efi/esrt.c
    @@ -180,7 +180,7 @@ static int esre_create_sysfs_entry(void *esre, int entry_num)
    rc = kobject_init_and_add(&entry->kobj, &esre1_ktype, NULL,
    "entry%d", entry_num);
    if (rc) {
    - kfree(entry);
    + kobject_put(&entry->kobj);
    return rc;
    }
    }
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-29 21:28    [W:8.738 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site