lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] platform/chrome: cros_ec_typec: Add a dependency on USB_ROLE_SWITCH
Hi Enric,

Thanks for the patch.

On Mon, Jun 29, 2020 at 12:32:23PM +0200, Enric Balletbo i Serra wrote:
> As reported by the kernel test robot the cros_ec_typec driver fails to
> build if the USB_ROLE_SWITCH is not selected, to fix that, add a
> dependency on that symbol. This fixes the following build error:
>
> drivers/platform/chrome/cros_ec_typec.c:133: undefined reference to `usb_role_switch_put'
> ld: drivers/platform/chrome/cros_ec_typec.o: in function `cros_typec_get_switch_handles':
> drivers/platform/chrome/cros_ec_typec.c:108: undefined reference to `fwnode_usb_role_switch_get'
> ld: drivers/platform/chrome/cros_ec_typec.c:117: undefined reference to `usb_role_switch_put'
>
> Fixes: 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: Prashant Malani <pmalani@chromium.org>

> ---
>
> drivers/platform/chrome/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
> index cf072153bdc5..a056031dee81 100644
> --- a/drivers/platform/chrome/Kconfig
> +++ b/drivers/platform/chrome/Kconfig
> @@ -218,6 +218,7 @@ config CROS_EC_TYPEC
> tristate "ChromeOS EC Type-C Connector Control"
> depends on MFD_CROS_EC_DEV && TYPEC
> depends on CROS_USBPD_NOTIFY
> + depends on USB_ROLE_SWITCH
> default MFD_CROS_EC_DEV
> help
> If you say Y here, you get support for accessing Type C connector
> --
> 2.27.0
>

\
 
 \ /
  Last update: 2020-06-29 21:24    [W:0.073 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site