lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 101/135] xhci: Fix incorrect EP_STATE_MASK
    Date
    From: Mathias Nyman <mathias.nyman@linux.intel.com>

    commit dceea67058fe22075db3aed62d5cb62092be5053 upstream.

    EP_STATE_MASK should be 0x7 instead of 0xf

    xhci spec 6.2.3 shows that the EP state field in the endpoint context data
    structure consist of bits [2:0].
    The old value included a bit from the next field which fortunately is a
    RsvdZ region. So hopefully this hasn't caused too much harm

    Cc: stable@vger.kernel.org
    Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
    Link: https://lore.kernel.org/r/20200624135949.22611-2-mathias.nyman@linux.intel.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/host/xhci.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
    index 0a3aa38b3c96e..a7f346529f913 100644
    --- a/drivers/usb/host/xhci.h
    +++ b/drivers/usb/host/xhci.h
    @@ -706,7 +706,7 @@ struct xhci_ep_ctx {
    * 4 - TRB error
    * 5-7 - reserved
    */
    -#define EP_STATE_MASK (0xf)
    +#define EP_STATE_MASK (0x7)
    #define EP_STATE_DISABLED 0
    #define EP_STATE_RUNNING 1
    #define EP_STATE_HALTED 2
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-29 21:02    [W:4.129 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site