lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/2] kconfig: qconf: don't show goback button on splitMode
On Tue, Jun 30, 2020 at 12:30 AM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
>
> the goback button does nothing on splitMode. So, why display
> it?


Hmm, I still see the goback button
on all of the three modes...



> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> scripts/kconfig/qconf.cc | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
> index d0bcc0b717f0..f49fbac91995 100644
> --- a/scripts/kconfig/qconf.cc
> +++ b/scripts/kconfig/qconf.cc
> @@ -437,9 +437,10 @@ void ConfigList::updateList(ConfigItem* item)
> if (rootEntry != &rootmenu && (mode == singleMode ||
> (mode == symbolMode && rootEntry->parent != &rootmenu))) {
> item = (ConfigItem *)topLevelItem(0);
> - if (!item)
> + if (!item && mode != symbolMode) {
> item = new ConfigItem(this, 0, true);
> - last = item;
> + last = item;
> + }
> }
> if ((mode == singleMode || (mode == symbolMode && !(rootEntry->flags & MENU_ROOT))) &&
> rootEntry->sym && rootEntry->prompt) {
> --
> 2.26.2
>


--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2020-06-30 05:56    [W:0.064 / U:9.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site