[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs

Hi Sameer

> > Maybe base issue for multiple codec support
> > is that simple_for_each_link() is caring first codec only ?
> Ideally I wanted to remove above two lines and allow empty codec
> list. But some users may expect the parsing to fail if no 'Codec' is
> found in the DAI link, hence did not remove above. If it is fine to
> remove above two lines it would be simpler. The loop inside
> simple_for_each_link() would anyway loop for each child node of DAI
> link and simple_dai_link_of_dpcm() can parse each 'np'.

Current simple-card is not assuming multi Codec,
thus, we need to update it correctly, not quick-hack.

I'm not sure how to do it, but it seems we need to update
many functions to support it, not only simple-card driver.
For example, simple-card-utils, soc-core, etc, etc...

I'm not sure, this is just my guess.
I'm happy if we can support it more easily :)

But, if it was difficult to keep compatibility on simple-card,
we/you need to have new one.
Actually, I had a plan to create more flexible sound card
driver, but it is not hi priority for me in these days.

Thank you for your help !!

Best regards
Kuninori Morimoto

 \ /
  Last update: 2020-06-30 03:25    [W:0.111 / U:12.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site