lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next 1/3] net: ipa: always report GSI state errors
From
Date
On 6/29/20 7:09 PM, Jakub Kicinski wrote:
> On Mon, 29 Jun 2020 16:37:36 -0500 Alex Elder wrote:
>> We check the state of an event ring or channel both before and after
>> any GSI command issued that will change that state. In most--but
>> not all--cases, if the state is something different than expected we
>> report an error message.
>>
>> Add error messages where missing, so that all unexpected states
>> provide information about what went wrong. Drop the parentheses
>> around the state value shown in all cases.
>>
>> Signed-off-by: Alex Elder <elder@linaro.org>
>
> nit:

Sorry about that. I'll fix this and run checkpatch on v2.

Thanks for your quick review.
-Alex

> CHECK: Alignment should match open parenthesis
> #105: FILE: drivers/net/ipa/gsi.c:1673:
> + dev_warn(dev,
> + "limiting to %u channels; hardware supports %u\n",
>
> CHECK: Alignment should match open parenthesis
> #120: FILE: drivers/net/ipa/gsi.c:1685:
> + dev_warn(dev,
> + "limiting to %u event rings; hardware supports %u\n",
>

\
 
 \ /
  Last update: 2020-06-30 03:04    [W:0.073 / U:26.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site