Messages in this thread | | | Date | Mon, 29 Jun 2020 17:09:12 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next 1/3] net: ipa: always report GSI state errors |
| |
On Mon, 29 Jun 2020 16:37:36 -0500 Alex Elder wrote: > We check the state of an event ring or channel both before and after > any GSI command issued that will change that state. In most--but > not all--cases, if the state is something different than expected we > report an error message. > > Add error messages where missing, so that all unexpected states > provide information about what went wrong. Drop the parentheses > around the state value shown in all cases. > > Signed-off-by: Alex Elder <elder@linaro.org>
nit:
CHECK: Alignment should match open parenthesis #105: FILE: drivers/net/ipa/gsi.c:1673: + dev_warn(dev, + "limiting to %u channels; hardware supports %u\n",
CHECK: Alignment should match open parenthesis #120: FILE: drivers/net/ipa/gsi.c:1685: + dev_warn(dev, + "limiting to %u event rings; hardware supports %u\n",
| |