lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening
On Mon, Jun 29, 2020 at 09:33:15PM +0000, Haiyang Zhang wrote:
>
>
> > -----Original Message-----
> > From: Andres Beltran <lkmlabelt@gmail.com>
> > Sent: Monday, June 29, 2020 4:02 PM
> > To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> > <haiyangz@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>;
> > wei.liu@kernel.org
> > Cc: linux-hyperv@vger.kernel.org; linux-kernel@vger.kernel.org; Michael
> > Kelley <mikelley@microsoft.com>; parri.andrea@gmail.com; Andres Beltran
> > <lkmlabelt@gmail.com>; David S . Miller <davem@davemloft.net>; Jakub
> > Kicinski <kuba@kernel.org>; netdev@vger.kernel.org
> > Subject: [PATCH v2 3/3] hv_netvsc: Use vmbus_requestor to generate
> > transaction IDs for VMBus hardening
> >
> > Currently, pointers to guest memory are passed to Hyper-V as
> > transaction IDs in netvsc. In the face of errors or malicious
> > behavior in Hyper-V, netvsc should not expose or trust the transaction
> > IDs returned by Hyper-V to be valid guest memory addresses. Instead,
> > use small integers generated by vmbus_requestor as requests
> > (transaction) IDs.
> >
> > Cc: David S. Miller <davem@davemloft.net>
> > Cc: Jakub Kicinski <kuba@kernel.org>
> > Cc: netdev@vger.kernel.org
> > Signed-off-by: Andres Beltran <lkmlabelt@gmail.com>
>
> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
>
>

Thanks Haiyang for reviewing.

David and Jakub:

This patch depends on the first patch. I intend to pick up this patch
via hyperv.git. This makes life easier for all of us. Let me know if you
disagree.

Wei.

\
 
 \ /
  Last update: 2020-06-30 00:28    [W:0.051 / U:6.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site