lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 153/265] net: qede: fix use-after-free on recovery and AER handling
    Date
    From: Alexander Lobakin <alobakin@marvell.com>

    [ Upstream commit ec6c80590bde6b5dfa4970fffa3572f1acd313ca ]

    Set edev->cdev pointer to NULL after calling remove() callback to avoid
    using of already freed object.

    Fixes: ccc67ef50b90 ("qede: Error recovery process")
    Signed-off-by: Alexander Lobakin <alobakin@marvell.com>
    Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
    Signed-off-by: Michal Kalderon <michal.kalderon@marvell.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/qlogic/qede/qede_main.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
    index 51bb5866a212c..26eb58e7e0765 100644
    --- a/drivers/net/ethernet/qlogic/qede/qede_main.c
    +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
    @@ -1247,6 +1247,7 @@ static void __qede_remove(struct pci_dev *pdev, enum qede_remove_mode mode)
    if (system_state == SYSTEM_POWER_OFF)
    return;
    qed_ops->common->remove(cdev);
    + edev->cdev = NULL;

    /* Since this can happen out-of-sync with other flows,
    * don't release the netdevice until after slowpath stop
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-29 23:59    [W:4.748 / U:0.592 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site