lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 136/265] ASoC: rockchip: Fix a reference count leak.
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    [ Upstream commit f141a422159a199f4c8dedb7e0df55b3b2cf16cd ]

    Calling pm_runtime_get_sync increments the counter even in case of
    failure, causing incorrect ref count if pm_runtime_put is not called in
    error handling paths. Call pm_runtime_put if pm_runtime_get_sync fails.

    Fixes: fc05a5b22253 ("ASoC: rockchip: add support for pdm controller")
    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Reviewed-by: Heiko Stuebner <heiko@sntech.de>
    Link: https://lore.kernel.org/r/20200613205158.27296-1-wu000273@umn.edu
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/rockchip/rockchip_pdm.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchip_pdm.c
    index 7cd42fcfcf38a..1707414cfa921 100644
    --- a/sound/soc/rockchip/rockchip_pdm.c
    +++ b/sound/soc/rockchip/rockchip_pdm.c
    @@ -590,8 +590,10 @@ static int rockchip_pdm_resume(struct device *dev)
    int ret;

    ret = pm_runtime_get_sync(dev);
    - if (ret < 0)
    + if (ret < 0) {
    + pm_runtime_put(dev);
    return ret;
    + }

    ret = regcache_sync(pdm->regmap);

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-29 23:49    [W:2.784 / U:0.516 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site