lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 191/265] test_objagg: Fix potential memory leak in error handling
    Date
    From: Aditya Pakki <pakki001@umn.edu>

    [ Upstream commit a6379f0ad6375a707e915518ecd5c2270afcd395 ]

    In case of failure of check_expect_hints_stats(), the resources
    allocated by objagg_hints_get should be freed. The patch fixes
    this issue.

    Signed-off-by: Aditya Pakki <pakki001@umn.edu>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    lib/test_objagg.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/lib/test_objagg.c b/lib/test_objagg.c
    index 72c1abfa154dc..da137939a4100 100644
    --- a/lib/test_objagg.c
    +++ b/lib/test_objagg.c
    @@ -979,10 +979,10 @@ err_check_expect_stats2:
    err_world2_obj_get:
    for (i--; i >= 0; i--)
    world_obj_put(&world2, objagg, hints_case->key_ids[i]);
    - objagg_hints_put(hints);
    - objagg_destroy(objagg2);
    i = hints_case->key_ids_count;
    + objagg_destroy(objagg2);
    err_check_expect_hints_stats:
    + objagg_hints_put(hints);
    err_hints_get:
    err_check_expect_stats:
    err_world_obj_get:
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-29 23:48    [W:4.431 / U:0.920 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site