lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 176/265] selftests/powerpc: Fix build failure in ebb tests
    Date
    From: Harish <harish@linux.ibm.com>

    [ Upstream commit 896066aa0685af3434637998b76218c2045142a8 ]

    We use OUTPUT directory as TMPOUT for checking no-pie option.

    Since commit f2f02ebd8f38 ("kbuild: improve cc-option to clean up all
    temporary files") when building powerpc/ from selftests directory, the
    OUTPUT directory points to powerpc/pmu/ebb/ and gets removed when
    checking for -no-pie option in try-run routine, subsequently build
    fails with the following:

    $ make -C powerpc
    ...
    TARGET=ebb; BUILD_TARGET=$OUTPUT/$TARGET; mkdir -p $BUILD_TARGET; make OUTPUT=$BUILD_TARGET -k -C $TARGET all
    make[2]: Entering directory '/home/linux-master/tools/testing/selftests/powerpc/pmu/ebb'
    make[2]: *** No rule to make target 'Makefile'.
    make[2]: Failed to remake makefile 'Makefile'.
    make[2]: *** No rule to make target 'ebb.c', needed by '/home/linux-master/tools/testing/selftests/powerpc/pmu/ebb/reg_access_test'.
    make[2]: *** No rule to make target 'ebb_handler.S', needed by '/home/linux-master/tools/testing/selftests/powerpc/pmu/ebb/reg_access_test'.
    make[2]: *** No rule to make target 'trace.c', needed by '/home/linux-master/tools/testing/selftests/powerpc/pmu/ebb/reg_access_test'.
    make[2]: *** No rule to make target 'busy_loop.S', needed by '/home/linux-master/tools/testing/selftests/powerpc/pmu/ebb/reg_access_test'.
    make[2]: Target 'all' not remade because of errors.

    Fix this by adding a suffix to the OUTPUT directory so that the
    failure is avoided.

    Fixes: 9686813f6e9d ("selftests/powerpc: Fix try-run when source tree is not writable")
    Signed-off-by: Harish <harish@linux.ibm.com>
    [mpe: Mention that commit that triggered the breakage]
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20200625165721.264904-1-harish@linux.ibm.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/powerpc/pmu/ebb/Makefile | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/powerpc/pmu/ebb/Makefile b/tools/testing/selftests/powerpc/pmu/ebb/Makefile
    index ca35dd8848b0a..af3df79d8163f 100644
    --- a/tools/testing/selftests/powerpc/pmu/ebb/Makefile
    +++ b/tools/testing/selftests/powerpc/pmu/ebb/Makefile
    @@ -7,7 +7,7 @@ noarg:
    # The EBB handler is 64-bit code and everything links against it
    CFLAGS += -m64

    -TMPOUT = $(OUTPUT)/
    +TMPOUT = $(OUTPUT)/TMPDIR/
    # Toolchains may build PIE by default which breaks the assembly
    no-pie-option := $(call try-run, echo 'int main() { return 0; }' | \
    $(CC) -Werror $(KBUILD_CPPFLAGS) $(CC_OPTION_CFLAGS) -no-pie -x c - -o "$$TMP", -no-pie)
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-29 23:47    [W:2.444 / U:0.872 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site