Messages in this thread | | | Subject | Re: [PATCH for v5.8 2/3] mm/swap: fix for "mm: workingset: age nonresident information alongside anonymous pages" | From | Vlastimil Babka <> | Date | Mon, 29 Jun 2020 12:25:12 +0200 |
| |
On 6/16/20 8:16 AM, js1304@gmail.com wrote: > From: Joonsoo Kim <iamjoonsoo.kim@lge.com> > > Non-file-lru page could also be activated in mark_page_accessed() > and we need to count this activation for nonresident_age. > > Note that it's better for this patch to be squashed into the patch > "mm: workingset: age nonresident information alongside anonymous pages".
Agreed.
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> --- > mm/swap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/swap.c b/mm/swap.c > index 667133d..c5d5114 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -443,8 +443,7 @@ void mark_page_accessed(struct page *page) > else > __lru_cache_activate_page(page); > ClearPageReferenced(page); > - if (page_is_file_lru(page)) > - workingset_activation(page); > + workingset_activation(page); > } > if (page_is_idle(page)) > clear_page_idle(page); >
| |