lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] f2fs: support to trace f2fs_bmap()
Hi Chao,

I love your patch! Perhaps something to improve:

[auto build test WARNING on f2fs/dev-test]
[also build test WARNING on v5.8-rc3 next-20200629]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Chao-Yu/f2fs-fix-wrong-return-value-of-f2fs_bmap_compress/20200628-203231
base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

In file included from include/trace/define_trace.h:102,
from include/trace/events/f2fs.h:1924,
from fs/f2fs/super.c:37:
include/trace/events/f2fs.h: In function 'trace_raw_output_f2fs_bmap':
>> include/trace/events/f2fs.h:1914:12: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'ino_t' {aka 'unsigned int'} [-Wformat=]
1914 | TP_printk("dev = (%d,%d), ino = %lu, lblock:%lld, pblock:%lld",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:368:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
368 | trace_seq_printf(s, print); \
| ^~~~~
include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
80 | PARAMS(print)); \
| ^~~~~~
include/trace/events/f2fs.h:1894:1: note: in expansion of macro 'TRACE_EVENT'
1894 | TRACE_EVENT(f2fs_bmap,
| ^~~~~~~~~~~
>> include/trace/events/f2fs.h:1914:2: note: in expansion of macro 'TP_printk'
1914 | TP_printk("dev = (%d,%d), ino = %lu, lblock:%lld, pblock:%lld",
| ^~~~~~~~~
In file included from include/trace/trace_events.h:402,
from include/trace/define_trace.h:102,
from include/trace/events/f2fs.h:1924,
from fs/f2fs/super.c:37:
include/trace/events/f2fs.h:1914:36: note: format string is defined here
1914 | TP_printk("dev = (%d,%d), ino = %lu, lblock:%lld, pblock:%lld",
| ~~^
| |
| long unsigned int
| %u

vim +1914 include/trace/events/f2fs.h

1895
1896 TP_PROTO(struct inode *inode, sector_t lblock, sector_t pblock),
1897
1898 TP_ARGS(inode, lblock, pblock),
1899
1900 TP_STRUCT__entry(
1901 __field(dev_t, dev)
1902 __field(ino_t, ino)
1903 __field(sector_t, lblock)
1904 __field(sector_t, pblock)
1905 ),
1906
1907 TP_fast_assign(
1908 __entry->dev = inode->i_sb->s_dev;
1909 __entry->ino = inode->i_ino;
1910 __entry->lblock = lblock;
1911 __entry->pblock = pblock;
1912 ),
1913
> 1914 TP_printk("dev = (%d,%d), ino = %lu, lblock:%lld, pblock:%lld",
1915 show_dev(__entry->dev),
1916 __entry->ino,
1917 (unsigned long long)__entry->lblock,
1918 (unsigned long long)__entry->pblock)
1919 );
1920

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2020-06-29 20:51    [W:0.045 / U:7.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site