lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v6 4/4] drm/bridge: lvds-codec: simplify error handling
    From
    Date
    On 26/06/2020 12:01, Andrzej Hajda wrote:
    > Using dev_err_probe code has following advantages:
    > - shorter code,
    > - recorded defer probe reason for debugging,
    > - uniform error code logging.
    >
    > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
    > ---
    > drivers/gpu/drm/bridge/lvds-codec.c | 10 +++-------
    > 1 file changed, 3 insertions(+), 7 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c
    > index 24fb1befdfa2..f19d9f7a5db2 100644
    > --- a/drivers/gpu/drm/bridge/lvds-codec.c
    > +++ b/drivers/gpu/drm/bridge/lvds-codec.c
    > @@ -71,13 +71,9 @@ static int lvds_codec_probe(struct platform_device *pdev)
    > lvds_codec->connector_type = (uintptr_t)of_device_get_match_data(dev);
    > lvds_codec->powerdown_gpio = devm_gpiod_get_optional(dev, "powerdown",
    > GPIOD_OUT_HIGH);
    > - if (IS_ERR(lvds_codec->powerdown_gpio)) {
    > - int err = PTR_ERR(lvds_codec->powerdown_gpio);
    > -
    > - if (err != -EPROBE_DEFER)
    > - dev_err(dev, "powerdown GPIO failure: %d\n", err);
    > - return err;
    > - }
    > + if (IS_ERR(lvds_codec->powerdown_gpio))
    > + return dev_err_probe(dev, PTR_ERR(lvds_codec->powerdown_gpio),
    > + "powerdown GPIO failure\n");
    >
    > /* Locate the panel DT node. */
    > panel_node = of_graph_get_remote_node(dev->of_node, 1, 0);
    >

    Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

    \
     
     \ /
      Last update: 2020-06-29 23:00    [W:8.491 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site