lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V3 10/10] clk: imx8qxp: Support module build
Date
Hi, Arnd


> Subject: Re: [PATCH V3 10/10] clk: imx8qxp: Support module build
>
> On Mon, Jun 29, 2020 at 8:06 AM Anson Huang <Anson.Huang@nxp.com>
> wrote:
> >
> > Support building i.MX8QXP clock driver as module.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
>
> I would just combine the per-soc patches into one, as they all have the same
> changelog text.

OK, I will merge those patches with same changelog text into one patch.
But for i.MX8QXP clock driver, as I need to add more changes about module author
etc., I will keep it as a separate patch.

>
> > diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c
> > b/drivers/clk/imx/clk-imx8qxp-lpcg.c
> > index 04c8ee3..8afaefc 100644
> > --- a/drivers/clk/imx/clk-imx8qxp-lpcg.c
> > +++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c
> > @@ -232,3 +232,4 @@ static struct platform_driver
> > imx8qxp_lpcg_clk_driver = { };
> >
> > builtin_platform_driver(imx8qxp_lpcg_clk_driver);
> > +MODULE_LICENSE("GPL v2");
>
> Same thing here: please try to make it possible to unload these drivers, and
> add MODULE_AUTHOR/MODULE_DESCRIPTION tags in addition to
> MODULE_LICENSE.
>

OK, will improve it in next patch series.

Thanks,
Anson
\
 
 \ /
  Last update: 2020-06-29 22:58    [W:0.069 / U:6.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site