Messages in this thread | | | Date | Mon, 29 Jun 2020 15:16:27 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH V4 3/3] cpufreq: Specify default governor on command line |
| |
On 29-06-20, 10:44, Quentin Perret wrote: > On Monday 29 Jun 2020 at 13:55:00 (+0530), Viresh Kumar wrote: > > static int __init cpufreq_core_init(void) > > { > > + struct cpufreq_governor *gov = cpufreq_default_governor(); > > + > > if (cpufreq_disabled()) > > return -ENODEV; > > > > cpufreq_global_kobject = kobject_create_and_add("cpufreq", &cpu_subsys.dev_root->kobj); > > BUG_ON(!cpufreq_global_kobject); > > > > + if (!strlen(default_governor)) > > Should we test '!strlen(default_governor) && gov' here actually? > We check the return value of cpufreq_default_governor() in > cpufreq_init_policy(), so I'm guessing we should do the same here to be > on the safe side.
With the current setup (the Kconfig option being a choice which selects one governor at least), it is not possible for gov to be NULL here. And so I didn't worry about it :)
-- viresh
| |