lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/3] reset: imx7: Support module build
Date
Hi, Arnd


> Subject: Re: [PATCH 1/3] reset: imx7: Support module build
>
> On Mon, Jun 29, 2020 at 12:45 PM Anson Huang <anson.huang@nxp.com>
> wrote:
> > > Subject: Re: [PATCH 1/3] reset: imx7: Support module build On Mon,
> > > Jun 29, 2020 at 12:25 PM Anson Huang <Anson.Huang@nxp.com> wrote:
> >
> > The reset driver normally won't be removed since it is necessary for
> > drivers which need it, it is just for Android GKI support, in this
> > case, do we need to change it to module_platform_driver()?
>
> Please at least try to do it, or explain in the changelog what went wrong if it
> doesn't work.
>
> I don't think "because Android GKI" should ever be the sole justification for a
> patch. Making drivers loadable module is a good idea regardless of GKI, and if
> you do that, then make it behave like any other loadable module.
>

OK, will do it in V2, BTW, I think there is nothing need to be done for .remove() callback,
can I just skip it or need to add a blank callback anyway?

Thanks,
Anson
\
 
 \ /
  Last update: 2020-06-29 22:53    [W:0.099 / U:4.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site