lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] ARM: dts: exynos: Fix missing empty reg/ranges property regulators on Trats
On Mon, Jun 29, 2020 at 09:50:26PM +0200, Sylwester Nawrocki wrote:
> Hi Krzysztof,
>
> On 6/29/20 21:33, Krzysztof Kozlowski wrote:
> > Remove the simple-bus compatible from a regulators node because its
> > children do not have any unit addresses. This fixes DTC warning:
> >
> > Warning (simple_bus_reg): /regulators/regulator-0: missing or empty reg/ranges property
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > arch/arm/boot/dts/exynos4210-trats.dts | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
> > index 3d791db6095c..cec413ee4490 100644
> > --- a/arch/arm/boot/dts/exynos4210-trats.dts
> > +++ b/arch/arm/boot/dts/exynos4210-trats.dts
> > @@ -31,8 +31,6 @@
> > };
> > regulators {
> > - compatible = "simple-bus";
>
> I think you would also need to remove the 'regulators' node altogether,
> otherwise with your change the subnodes below won't get parsed and the
> regulators will not get registered.

Good point, I actually did not test this patch. Let me recheck and send
a follow up.

Thanks for review!

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2020-06-29 22:48    [W:0.079 / U:3.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site